Added num/malachite features for format crate #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h7kanna
force-pushed
the
fix-num-malachite-features-main
branch
2 times, most recently
from
aa86d62 to
a398b11
Compare
youknowone
reviewed
Dec 27, 2023
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
Thank you for contributing! Could you please check if we can go without explicit malachite-bigint and num-bigint features or not?
ast/Cargo.toml
Outdated
Comment on lines
19
to
20
| malachite-bigint = ["dep:malachite-bigint"] | ||
| num-bigint = ["dep:num-bigint"] |
Member
There was a problem hiding this comment.
Do we need these lines? Isn't an optional dependency name itself a dependency name? Please let me know if I am missing recently changed recommendation or guideline.
Contributor
Author
There was a problem hiding this comment.
Yes, you are right. these are not needed. I will update this and the PR to RustPython as well.
h7kanna
force-pushed
the
fix-num-malachite-features-main
branch
from
4efe36b to
2cf5c64
Compare
h7kanna
force-pushed
the
fix-num-malachite-features-main
branch
from
2cf5c64 to
99284e3
Compare
Contributor
Author
|
Hi @youknowone, Removed the unnecessary features(rebased). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make
malachite-bigintoptional andnum-bigintoptin for RustPythonformatcrate needs the features.Trying to solve for RustPython/RustPython#5130 (comment)